Support Migration Notice: To update migrated JIRA cases click here to open a new case use www.vmware.com/go/sr | vFabric Hyperic 5.7.0 is Now Available

Hyperic HQ

ConfigSchema not thread safe

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 4.6.5
  • Case Links:
    none
  • HQ Fix Version:
    4.7
  • Regression:
    No

Description

A couple issues:

1) ConfigSchema.getOptions() returns a live list, meaning callers have access to the underlying list of ConfigOptions. This should not be the case, modifications should only be done via the public APIs on ConfigSchema. Change ConfigSchema to return a copied, immutable list.

2) All access to configOptions needs to be synchronized.

Activity

Hide
Ryan Morgan added a comment -


Change getOptions() to return an immutable copy, synchronize access to the optionList. No changes to serialUID required.

Show
Ryan Morgan added a comment - Change getOptions() to return an immutable copy, synchronize access to the optionList. No changes to serialUID required.
Hide
Zvika Messing added a comment -

verified in hyperic 4.6.5 RC2. configScheme.getOptions is called every time you change go to the inventory view of a resource. this seems to work.

Show
Zvika Messing added a comment - verified in hyperic 4.6.5 RC2. configScheme.getOptions is called every time you change go to the inventory view of a resource. this seems to work.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
    Last comment:
    2 years, 9 weeks, 1 day ago