Support Migration Notice: To update migrated JIRA cases click here to open a new case use www.vmware.com/go/sr | vFabric Hyperic 5.7.0 is Now Available

HQApi

Misspelled XML attribute name for metric defaultOn in HQU web services

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Case Links:
    none

Description

Mis-spelled XML attribute name for metric defaultOn in HQU web services

curl -uhqadmin http://localhost:7080/hqu/hqapi1/metric/getMetric.hqu?id=10001 | xmllint --format -
Enter host password for user 'hqadmin':

<?xml version="1.0"?>
<MetricResponse>
<Status>Success</Status>
<Metric id="10001" interval="60000" enabled="true" name="Availability" defalutOn="true" indicator="true" collectionType="0">
<MetricTemplate id="11128" name="Availability" alias="Availability" units="percentage" plugin="system" indicator="true" defaultOn="true" collectionType="0" defaultInterval="60000" category="AVAILABILITY"/>
</Metric>
</MetricResponse>

Note that a grep for the string defalutOn in the server installation tree yields the following result if that helps:

./server-4.2.0-EE/hq-engine/server/default/deploy/hq.ear/hq.war/hqu/hqapi1/app/MetricController.groovy: defalutOn : m.template.defaultOn,

Issue Links

Activity

Hide
Ryan Morgan added a comment -

Bug fixed and test added on all 3 branches:

To git@github.com:hyperic/hqapi.git
b950ccb..a0de5d4 hqapi-1.0 -> hqapi-1.0
4c66db5..33e1eaf hqapi-2.x -> hqapi-2.x
4440ed8..300f782 master -> master

This is a fairly major issue since if the XML listing is used to re-sync it would cause the metrics to be updated to defaultOn = false.

I'll close this ticket out when we have pushed the API binaries in HQ. In the meantime, the CI server has picked up these changes so they are available for all 3 versions of the API on hudson.hyperic.com

Show
Ryan Morgan added a comment - Bug fixed and test added on all 3 branches: To git@github.com:hyperic/hqapi.git b950ccb..a0de5d4 hqapi-1.0 -> hqapi-1.0 4c66db5..33e1eaf hqapi-2.x -> hqapi-2.x 4440ed8..300f782 master -> master This is a fairly major issue since if the XML listing is used to re-sync it would cause the metrics to be updated to defaultOn = false. I'll close this ticket out when we have pushed the API binaries in HQ. In the meantime, the CI server has picked up these changes so they are available for all 3 versions of the API on hudson.hyperic.com
Hide
Ryan Morgan added a comment -


HQApi binaries have been pushed to 3.0 on trunk.

Show
Ryan Morgan added a comment - HQApi binaries have been pushed to 3.0 on trunk.
Hide
Kashyap Parikh added a comment -

Moving issues already resolved in Sake to 4.3.

Show
Kashyap Parikh added a comment - Moving issues already resolved in Sake to 4.3.
Hide
Ilayaperumal Gopinathan added a comment -

Fix looks good.

The "defaultOn" attribute is correctly displayed.

Verification version: HQ 4.3 #1283.

Show
Ilayaperumal Gopinathan added a comment - Fix looks good. The "defaultOn" attribute is correctly displayed. Verification version: HQ 4.3 #1283.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
    Last comment:
    4 years, 20 weeks, 1 day ago